combined blocklyArrowTop and blocklyArrowBottom styling into the blocklyDropDownArrow styling#8338
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
|
Thanks for looking into this! But itt looks like this issue is a bit more complex than I expected :/ I don't know that combining them quite works because of how the layering of the elements works out. Would you be interested in working on #8312 instead? |
|
@BeksOmega Sure, I will look into it. |
2 participants
The basics
The details
Combine the styling of
blocklyArrowTopandblocklyArrowBottominto theblocklyDropDownArrowand remove the assignment ofblocklyArrowTopandblocklyArrowBottom.Resolves
Fixes #8323